Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs for build_id & multi-config #161

Merged
merged 1 commit into from
Mar 1, 2017
Merged

Conversation

memsharded
Copy link
Member

No description provided.

that allows consumers to reuse an existing package without building it again from sources.

The other type of information would be C/C++ build information, as include paths, library names, or
compile flags
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks confusing to me. I wouldn't say that a package identifier is an information for me, the consumer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, it is printed in the conan info command, is useful information for consumers of the package, to know which binary they are actually using for a given configuration.

But, yes, I agree that the title/description could be improved.

else:
for config in ("Debug", "Release"):
self.output.info("Building %s" % config)
self.run('cmake "%s" %s -DCMAKE_BUILD_TYPE=%s'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new configure/build helpers?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. The helpers use the standard cmake.command_line which depend on `sèttings.build_type`` in this case not defined. So I am manually overriding the behavior. Probably it could be wrapped in another cmake helper method.

Package IDs
------------

package_id
Copy link
Contributor

@lasote lasote Feb 28, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about this file in the docs. Maybe all this should go to conanfile.py page and this page just explain the general why and link to conanfile.py page.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And maybe the conanfile.py page should be splitted in several subpages. It's becoming too big.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nop, the conanfile_py.rst if you meant that, is just for package consumers. This is only relevant for package creators, and I think it should go inside the "Creating packages section".

@memsharded memsharded merged commit 8985227 into conan-io:master Mar 1, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants